Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extinguish fires when there is no oxygen #406

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: extinguish fires when there is no oxygen #406

wants to merge 2 commits into from
+210 −3

Conversation

Roelymole
Copy link
Contributor

@Roelymole Roelymole commented Feb 1, 2025 •
edited
Loading

  • Prevent candles being lit when there is no oxygen.
  • Extinguish soul torches/lanterns.
  • Extinguish campfires.
  • Update the deprecated TorchBlockMixin and LanternBlockMixin.
  • Extinguish fires which are caused by sources other than fire charges/flint and steel.
  • Don't extinguish when there is oxygen provided by an oxygen sealer or oxygen bubble distributor.
  • Prevent entities from being set on fire.
  • Generalize methods to make use of the #minecraft:creeper_igniters tag.

@Roelymole
fix: prevented candles from being lit when there is no oxygen and als…
0848ab3 
…o extinguish soul torches/lanterns
@Roelymole
fix: extinguish campfires when they are placed in a non-breathable at…
799913e 
…mosphere and remove unused imports from AbstractCandleBlockMixin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Roelymole